[gnutls-devel] libtasn1 | Minor fixes for code readability (!113)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Thu Feb 20 23:31:32 CET 2025




Daiki Ueno commented: https://gitlab.com/gnutls/libtasn1/-/merge_requests/113#note_2359456420


> Can never make up my mind of these kind of inline code review comments are workable or not...

I still can't see your comment; perhaps it might be marked as "Pending"? Such comments are only published after you submit the [review](https://docs.gitlab.com/user/project/merge_requests/reviews/#submit-a-review) with the "Finish review" button below the page.

> Hmm. Doesn't `asn1_static_node_st` have to match the struct in `int.h`?

I don't think it's relevant here; while it has a similar name, it is used for different purposes and there is an explicit conversion function (`asn1_array2tree`).

The removed duplicated struct I meant is f21ac35f6ea131cef3ce3636aa6da7851c81762b (`node_asn_struct`, the previous name of `asn1_node_st`).

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/libtasn1/-/merge_requests/113#note_2359456420
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250220/42330d83/attachment.html>


More information about the Gnutls-devel mailing list