[gnutls-devel] libtasn1 | Minor fixes for code readability (!113)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Thu Feb 20 16:22:32 CET 2025




Simon Josefsson commented: https://gitlab.com/gnutls/libtasn1/-/merge_requests/113#note_2358741559


I put it here:

https://gitlab.com/gnutls/libtasn1/-/merge_requests/113/diffs#note_2358283330

Can never make up my mind of these kind of inline code review comments are workable or not...

Hmm. Doesn't `asn1_static_node_st` have to match the struct in `int.h`?  I see they diverged already.  So maybe you are right that these doesn't have to be synced any longer?!  This happened in 2012 with the addition of `name_hash` so it seems we should have noticed any real problem because of the divergence already?  I didn't analyze this fully...

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/libtasn1/-/merge_requests/113#note_2358741559
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250220/023be042/attachment.html>


More information about the Gnutls-devel mailing list