[gnutls-devel] GnuTLS | lib/psk: add null check for binder algo (!2009)

[Read-only notification of GnuTLS library development activities]

Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/2009#note_2691781603


While you are at it, would you mind adding a unit test that exercises the `_credentials2` functions? Maybe that could be done by extending the existing tests, e.g., tests/psk-file.c.

I would also suggest changing `gnutls_psk_allocate_server_credentials2` as well, so if `mac` is `GNUTLS_MAC_UNKNOWN`, do not call `_gnutls_mac_to_entry(mac)` but just set `(*sc)->binder_algo = NULL`; that would make the auto-detection more explicit and avoid linear lookup for the NULL entry.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2009#note_2691781603
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250818/80e17f2d/attachment.html>