[gnutls-devel] GnuTLS | lib/psk: add null check for binder algo (!2009)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Mon Aug 18 05:32:50 CEST 2025



Wilfred Mallawa created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2009

Project:Branches: twilfredo/gnutls:wilfred/fixup-psk-binder-algo to gnutls/gnutls:master
Author:   Wilfred Mallawa




<!-- Add a description of the new feature/bug fix. Reference any relevant bugs. -->

* lib/psk: add null check for binder algo

Currently, `pskcred->binder_algo` is used without checking first if it
is valid. This can lead to a NULL pointer dereference in cases such as
[1]. This patch adds NULL check `pskcred->binder_algo` before using it.

This patch was tested with the same conditions specified in [1] to ensure the segmentation fault no longer occurs.

[1] https://gitlab.com/gnutls/gnutls/-/issues/1729

Fix Suggested by: Daiki Ueno <ueno at gnu.org>

Signed-off-by: Wilfred Mallawa <wilfred.mallawa at wdc.com>

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [N/A] Code modified for feature
 * [N/A] Test suite updated with functionality tests
 * [N/A] Test suite updated with negative tests
 * [N/A] Documentation updated / NEWS entry present (for non-trivial changes)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2009
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250818/e6459077/attachment-0001.html>


More information about the Gnutls-devel mailing list