[gnutls-devel] GnuTLS | wrap_nettle_hash_exists: add missing hash algorithms (!1473)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Mon Sep 20 13:38:34 CEST 2021

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1473 was reviewed by Daiki Ueno

Daiki Ueno commented on a discussion on lib/nettle/mac.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1473#note_681935287

> +	case GNUTLS_DIG_SHAKE_128:
> +	case GNUTLS_DIG_SHAKE_256:
> +		return 1;

Makes sense; updated

Daiki Ueno commented on a discussion on tests/simple.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1473#note_681935289

>  				fail("gnutls_sign id's doesn't match\n");
> +
> +			if (gnutls_sign_is_secure(algs[i])) {

It was intended for extra safety (as `gnutls_digest_get_id` only succeeds with implemented algorithms), but as the test still succeeds without this check, I have removed it.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1473
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210920/c6df5f3d/attachment.html>

More information about the Gnutls-devel mailing list