[gnutls-devel] GnuTLS | wrap_nettle_hash_exists: add missing hash algorithms (!1473)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Mon Sep 20 12:19:08 CEST 2021

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1473 was reviewed by Alexander Sosedkin

Alexander Sosedkin started a new discussion on lib/nettle/mac.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1473#note_681858863

> +	case GNUTLS_DIG_SHAKE_128:
> +	case GNUTLS_DIG_SHAKE_256:
> +		return 1;

I'd prefer a simplified flow with only two returns:

	switch (algo) {
	case A:
	case B:
#ifdef cond CD
	case C:
	case D:
#ifdef cond EF
	case E:
	case F:
		return 1;
		return 0;

Should be shorter as well.

Alexander Sosedkin started a new discussion on tests/simple.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1473#note_681858864

>  				fail("gnutls_sign id's doesn't match\n");
> +
> +			if (gnutls_sign_is_secure(algs[i])) {

Why is that check needed?

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1473
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210920/348d7e2c/attachment.html>

More information about the Gnutls-devel mailing list