[gnutls-devel] GnuTLS | Fix issues in record_size_limit extension handling (!879)

[Development of GNU's TLS library]

Hubert Kario started a new discussion on lib/ext/record_size_limit.c:

>  	if (new_size < MIN_RECORD_SIZE)
>  		return 0;
>  
> -	session->internals.hsk_flags |= HSK_RECORD_SIZE_LIMIT_NEGOTIATED;
> +	/* if a record size larger than user specified maximum, ignore it */
> +	if (new_size > session->security_parameters.max_record_send_size)
> +		return 0;
>  
> -	/* if a larger record size limit than the protocol limit is
> -	 * provided by the peer, ignore it and stick to the default */
> -	if (unlikely(new_size > DEFAULT_MAX_RECORD_SIZE))
> -		return gnutls_assert_val(0);
> +	session->internals.hsk_flags |= HSK_RECORD_SIZE_LIMIT_NEGOTIATED;
>  
> -	session->security_parameters.max_record_send_size = new_size;

the comment was correct - if the new_size is bigger than the MAX_RECORD_SIZE, then the agreed upon value *is* the max record size (it may change in the future when new extensions allow negotiating values above 2^14, but it's not the case now)

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/merge_requests/879#note_137186072
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20190131/06ce1ee0/attachment.html>