[gnutls-devel] Missing function. Where is version_to_entry defined?

[Nikos Mavrogiannopoulos]

On Thu, Feb 19, 2015 at 12:53 AM, JONES, BILL <rj7252 at att.com> wrote:
>>> "gnutls-3.3.11/lib/system.c", line 684: warning: argument #2 is incompatible with prototype:
>>>         prototype: pointer to pointer to const char : "/appl/local-201501ss/include/iconv.h", line 83
>>>         argument : pointer to pointer to char
>>I don't see anything const in the posix definition of this function.
> In gnu/libiconv-1.14/include/iconv.h, I see:
> extern LIBICONV_DLL_EXPORTED size_t iconv (iconv_t cd, const char* * inbuf, size_t *inbytesleft, char* * outbuf, size_t *outbytesleft);
> which translates to line 83 in the resulting iconv.h
> extern size_t iconv (iconv_t cd, const char* * inbuf, size_t *inbytesleft, char* * outbuf, size_t *outbytesleft);
> If this is wrong, then your suggesting that the libiconv team needs to fix this?

In glibc's iconv there no const either. However, I don't see why the
compiler needs to warn on that anyway.

>>>  gnutls-3.3.11/src/certtool-cfg.c", line 1104: warning: shift count negative or too big: >> 32
>>Not sure what is the issue there. The integer shifted is a 64-bit one.
> So the line is,
>                 default_serial[0] = default_serial_int >> 32;
> where default_serial is 32bits and default_serial_int is 64bits.
>         unsigned long default_serial_int;
>         uint32_t default_serial[2];
> Is it being upset about the size of default_serial?

It's a strange warning. I'd expect the shift to be evaluated first. If
you cast to default_serial[0] = (int64_t)(default_serial_int >> 32),
does it still output a warning?

regards,
Nikos