[gnutls-devel] Missing function. Where is version_to_entry defined?

[JONES, BILL]

Nikos,

Thanks for looking at these.

>> "gnutls-3.3.11/lib/system.c", line 684: warning: argument #2 is incompatible with prototype:
>>         prototype: pointer to pointer to const char : "/appl/local-201501ss/include/iconv.h", line 83
>>         argument : pointer to pointer to char
>
>I don't see anything const in the posix definition of this function.

In gnu/libiconv-1.14/include/iconv.h, I see:

extern LIBICONV_DLL_EXPORTED size_t iconv (iconv_t cd, const char* * inbuf, size_t *inbytesleft, char* * outbuf, size_t *outbytesleft);
which translates to line 83 in the resulting iconv.h
extern size_t iconv (iconv_t cd, const char* * inbuf, size_t *inbytesleft, char* * outbuf, size_t *outbytesleft);

If this is wrong, then your suggesting that the libiconv team needs to fix this?


>>  gnutls-3.3.11/src/certtool-cfg.c", line 1104: warning: shift count negative or too big: >> 32
>
>Not sure what is the issue there. The integer shifted is a 64-bit one.

So the line is, 
                default_serial[0] = default_serial_int >> 32;

where default_serial is 32bits and default_serial_int is 64bits.
        unsigned long default_serial_int;
        uint32_t default_serial[2];

Is it being upset about the size of default_serial?

Bill

-----Original Message-----
From: Nikos Mavrogiannopoulos [mailto:n.mavrogiannopoulos at gmail.com] On Behalf Of Nikos Mavrogiannopoulos
Sent: Wednesday, February 18, 2015 5:09 PM
To: JONES, BILL
Cc: bugs at gnutls.org
Subject: Re: [gnutls-devel] Missing function. Where is version_to_entry defined?

On Mon, 2015-02-16 at 17:04 +0000, JONES, BILL wrote:

> Here are other warnings showing up:
> "gnutls-3.3.11/lib/x509/pkcs12_encr.c", line 140: warning: enum type mismatch: arg #1
> rc = _gnutls_hash_fast(me->id, hash, mac_len,
>                        hash);
> should this be:
> rc = _gnutls_hash_fast((gnutls_digest_algorithm_t)me->id, hash, mac_len,
>                        hash);

Applied this cast in master.

> "gnutls-3.3.11/lib/system.c", line 684: warning: argument #2 is incompatible with prototype:
>         prototype: pointer to pointer to const char : "/appl/local-201501ss/include/iconv.h", line 83
>         argument : pointer to pointer to char

I don't see anything const in the posix definition of this function.

>  gnutls-3.3.11/src/certtool-cfg.c", line 1104: warning: shift count negative or too big: >> 32

Not sure what is the issue there. The integer shifted is a 64-bit one.

> "gnutls-3.3.11/src/certtool.c", line 1131: warning: integer overflow detected: op "<<"

I've added an explicit cast to unsigned int in the macro. Should solve
that.

regards,
Nikos