[gnutls-devel] Important Guile bug fix

[Ludovic Courtès]

Hello,

Nikos privately reported failures in the test suite of the Guile
bindings, which would manifest like this:

--8<---------------cut here---------------start------------->8---
make  check-TESTS
make[1]: Entering directory `/home/ludo/src/gnutls-3.2.1/+build/guile/tests'
/bin/sh: line 5:  5840 Floating point exception(core dumped) GUILE_AUTO_COMPILE=0 GUILE_WARN_DEPRECATED=detailed ../../guile/pre-inst-guile -L ../../../guile/tests ${dir}$tst
FAIL: anonymous-auth.scm
`set-session-certificate-type-priority!' is deprecated, use `set-session-priorities!' instead
`set-session-kx-priority!' is deprecated, use `set-session-priorities!' instead
`set-session-protocol-priority!' is deprecated, use `set-session-priorities!' instead
`set-session-cipher-priority!' is deprecated, use `set-session-priorities!' instead
`set-session-mac-priority!' is deprecated, use `set-session-priorities!' instead
`uniform-vector-write' is deprecated. Use `put-bytevector' from
`(rnrs io ports)' instead.
`set-session-certificate-type-priority!' is deprecated, use `set-session-priorities!' instead
`set-session-kx-priority!' is deprecated, use `set-session-priorities!' instead
`set-session-protocol-priority!' is deprecated, use `set-session-priorities!' instead
`set-session-cipher-priority!' is deprecated, use `set-session-priorities!' instead
`set-session-mac-priority!' is deprecated, use `set-session-priorities!' instead
`uniform-vector-read!' is deprecated. Use `get-bytevector-n!' from
`(rnrs io ports)' instead.
PASS: session-record-port.scm
`uniform-vector-read!' is deprecated. Use `get-bytevector-n!' from
`(rnrs io ports)' instead.
PASS: pkcs-import-export.scm
PASS: errors.scm
`uniform-vector-read!' is deprecated. Use `get-bytevector-n!' from
`(rnrs io ports)' instead.
PASS: x509-certificates.scm
/bin/sh: line 5:  5894 Segmentation fault      (core dumped) GUILE_AUTO_COMPILE=0 GUILE_WARN_DEPRECATED=detailed ../../guile/pre-inst-guile -L ../../../guile/tests ${dir}$tst
FAIL: x509-auth.scm
PASS: priorities.scm
`uniform-vector-read!' is deprecated. Use `get-bytevector-n!' from
`(rnrs io ports)' instead.
PASS: openpgp-keys.scm
`uniform-vector-read!' is deprecated. Use `get-bytevector-n!' from
`(rnrs io ports)' instead.
PASS: openpgp-keyring.scm
/bin/sh: line 5:  5938 Segmentation fault      (core dumped) GUILE_AUTO_COMPILE=0 GUILE_WARN_DEPRECATED=detailed ../../guile/pre-inst-guile -L ../../../guile/tests ${dir}$tst
FAIL: openpgp-auth.scm
PASS: srp-base64.scm
===================================
3 of 11 tests failed
Please report to bug-gnutls at gnu.org
===================================
make[1]: *** [check-TESTS] Error 1
--8<---------------cut here---------------end--------------->8---

For some reason, the bugs would only show up when using Debian’s binary
of Guile 2.0.5 on x86_64.  However, in hindsight, this was an obvious
mistake.

Commit 55e8943 in ‘master’ fixes it AFAICS.  Nikos, can you confirm?
Also, could you backport the fix to the live branches?

I haven’t tested it with the old Guile 1.8, but I guess it should work too.

Thanks,
Ludo’.