More PKCS#11 fixes for gnutls master

Nikos Mavrogiannopoulos nmav at gnutls.org
Mon Aug 1 18:00:48 CEST 2011


On 08/01/2011 11:53 AM, Stef Walter wrote:
> Attached are three more fixes to gnutls master for bugs and documentation.

Applied.

> Do these changes look okay? Would it be better to deprecate or change
> the gnutls_pkcs11_init() function, rather than just marking the argument
> as unused?

No reason to deprecate it. The argument was there for extensibility (due
to pakchois operation).

> commit d5c239f7542916b4fd50386476256c89d8cef58b
> Author: Stef Walter <stefw at collabora.co.uk>
> Date:   Mon Aug 1 11:11:01 2011 +0200
> 
>     When finding private keys fail, return error code.
> 
>      * Previously this would result in an endless loop.

I don't remember why I had that loop on errors.

thanks,
Nikos




More information about the Gnutls-devel mailing list