More PKCS#11 fixes for gnutls master

Stef Walter stefw at collabora.co.uk
Mon Aug 1 11:53:58 CEST 2011


Attached are three more fixes to gnutls master for bugs and documentation.

Do these changes look okay? Would it be better to deprecate or change
the gnutls_pkcs11_init() function, rather than just marking the argument
as unused?

Stef



commit 938f959a23b05ea2407bef067d54ce8b1e3cb6ec
Author: Stef Walter <stefw at collabora.co.uk>
Date:   Mon Aug 1 11:12:57 2011 +0200

    Don't try to do PKCS#11 login if session is already logged in.

     * It is possible for new PKCS#11 sessions to be logged in if
       another logged in session already exists.
     * In these cases, don't log in, but detect the condition and
       return success.

commit d5c239f7542916b4fd50386476256c89d8cef58b
Author: Stef Walter <stefw at collabora.co.uk>
Date:   Mon Aug 1 11:11:01 2011 +0200

    When finding private keys fail, return error code.

     * Previously this would result in an endless loop.

commit c68258d60c35426a89081705874b6d2acbba0ed9
Author: Stef Walter <stefw at collabora.co.uk>
Date:   Mon Aug 1 09:45:44 2011 +0200

    Mark the config argument of gnutls_pkcs11_init() as unused

     * Since its no longer used.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Mark-the-config-argument-of-gnutls_pkcs11_init-as-un.patch
Type: text/x-patch
Size: 2030 bytes
Desc: not available
URL: </pipermail/attachments/20110801/514ebf9a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-When-finding-private-keys-fail-return-error-code.patch
Type: text/x-patch
Size: 849 bytes
Desc: not available
URL: </pipermail/attachments/20110801/514ebf9a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Don-t-try-to-do-PKCS-11-login-if-session-is-already-.patch
Type: text/x-patch
Size: 1584 bytes
Desc: not available
URL: </pipermail/attachments/20110801/514ebf9a/attachment-0002.bin>


More information about the Gnutls-devel mailing list