Minor fixes for gnutls 2.9.4

Simon Josefsson simon at josefsson.org
Mon Aug 31 13:00:36 CEST 2009


Fabian Keil <fk at fabiankeil.de> writes:

> The attached patches fix a few minor issues in
> gnutls-20090829.tar.bz2, most of them pointed out by clang.

Thank you, I have applied them all except for 0005 which I decided to
solve differently.

> fk at r500 ~/git/gnutls/gnutls-2.9.4 $cat -n lib/opencdk/misc.c | grep 12[34]
>    123    for (node = root->next; node; node = node->next)
>    124      return node;
>
> and wonder if an if block wouldn't be more suitable here.

Or why not just 'return root->next'?  The code looks strange to me, but
I don't want to change it without a selftest that uses that code.

/Simon





More information about the Gnutls-devel mailing list