Minor fixes for gnutls 2.9.4

[Fabian Keil]

The attached patches fix a few minor issues in
gnutls-20090829.tar.bz2, most of them pointed out by clang.

The first three ones fix sanity checks in print_* functions,
then there's a patch to improve the code clarity in crypt.c,
one that marks what looks like a bug in _gnutls_srp_pwd_read_entry()
and finally a couple of patches for write-only variables and dead
stores which may or may not be intentional.

Patch 0005 removes an apparently unnecessary (and insufficient)
NULL pointer check, and while double checking the diff I also
noticed the following code:

fk at r500 ~/git/gnutls/gnutls-2.9.4 $cat -n lib/opencdk/misc.c | grep 12[34]
   123    for (node = root->next; node; node = node->next)
   124      return node;

and wonder if an if block wouldn't be more suitable here.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-In-print_crl-initialize-aki_idx-and-crl_nr-once-befo.patch
Type: text/x-patch
Size: 1041 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-In-print_crq-initialize-challenge-and-extensions-onc.patch
Type: text/x-patch
Size: 905 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-In-print_extensions-initialize-_idx-variables-once-b.patch
Type: text/x-patch
Size: 1369 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-In-print_extensions-declare-the-_idx-variables-as-in.patch
Type: text/x-patch
Size: 1148 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-In-cdk_strlist_next-root-is-expected-to-be-non-NULL-.patch
Type: text/x-patch
Size: 729 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-In-main-rename-salt-to-salt_size-and-don-t-bother-re.patch
Type: text/x-patch
Size: 1240 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Mark-what-looks-like-a-bug-in-in-_gnutls_srp_pwd_rea.patch
Type: text/x-patch
Size: 935 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Remove-duplicates.-Two-exact-ones-and-a-pretty-close.patch
Type: text/x-patch
Size: 1771 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Remove-write-only-variable-tmp_size-in-_pkcs12_decod.patch
Type: text/x-patch
Size: 1046 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Remove-write-only-variable-sep_ar_idx-in-split_multi.patch
Type: text/x-patch
Size: 1482 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-Remove-write-only-variable-info-in-gen_rsa_export_se.patch
Type: text/x-patch
Size: 1053 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-Remove-write-only-variable-info-in-_gnutls_proc_cert.patch
Type: text/x-patch
Size: 926 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-Remove-dead-store-in-pkcs12_info.patch
Type: text/x-patch
Size: 638 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-Remove-dead-store-in-pwd_put_values.patch
Type: text/x-patch
Size: 612 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-Remove-dead-store-in-gnutls_x509_crt_list_import.patch
Type: text/x-patch
Size: 663 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-Remove-dead-store-in-_gnutls_io_write_buffered.patch
Type: text/x-patch
Size: 661 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017-Remove-dead-store-in-listen_socket.patch
Type: text/x-patch
Size: 638 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: </pipermail/attachments/20090829/b1e7dbfb/attachment.pgp>