lib/opencdk/read-packet.c: read_s2k() implementation

[Daniel Kahn Gillmor]

On Fri 2008-06-27 06:21:12 -0400, Nikos Mavrogiannopoulos wrote:

>  In a few days I'll merge with the new opencdk code in the
> development branch (changes almost all code), thus I'd appreciate if
> you could port your patch there.

It's not clear to me what branch you're specifically talking about.  I
see no branches named anything like "new opencdk" or "development" --
do you mean "gnutls_with_ext_mpi" ?

In my message on the "2.6.x goals" thread [0], i asked if me doing
work on these would be likely to collide with anyone else's work, and
got no response from you.  It would be useful for collaboration if we
can communicate with each other about this sort of thing.  Sorry for
the miscommunication from my end!

If the branch you're referring to *is* gnutls_with_ext_mpi, then it's
not clear to me how to port this properly.  CDK_PKT_SYMKEY_ENC is the
packet type whose parser contained the code i ended up moving into
read_s2k.  But CDK_PKT_SYMKEY_ENC appears to have been removed from
opencdk.h on the gnutls_with_ext_mpi branch, despite being clearly
defined in the standard [1].  Any reason this was removed?  It seems
like a useful packet type for OpenCDK to be able to handle.

I'm attaching an (untested) patch against the gnutls_with_ext_mpi
branch, which at least fleshes out the read_s2k function.

It's untested because when i still don't know how to build from the
git repo.  The developer's site says [2] "Build GnuTLS/libtasn1 by
running 'make' twice (once to run autoreconf and configure and another
time to build the code)", but when i try, even the first make fails:

[0 dkg at squeak git-gnutls]$ git status
# Not currently on any branch.
# Changed but not updated:
#   (use "git add <file>..." to update what will be committed)
#
#	modified:   lib/opencdk/read-packet.c
#
no changes added to commit (use "git add" and/or "git commit -a")
[1 dkg at squeak git-gnutls]$ make
for f in po/*.po.in; do \
		cp $f `echo $f | sed 's/.in//'`; \
	done
mv build-aux/config.rpath build-aux/config.rpath-
test -f ./configure || autoreconf --install
mv build-aux/config.rpath- build-aux/config.rpath
./configure --enable-developer-mode --enable-gtk-doc
configure: error: cannot find install-sh or install.sh in build-aux "."/build-aux
make: *** [bootstrap] Error 1
[2 dkg at squeak git-gnutls]$ ls -l build-aux/
total 44
-rwxr-xr-x 1 dkg dkg 18343 2008-06-27 09:25 config.rpath
-rwxr-xr-x 1 dkg dkg 12050 2008-05-03 11:06 gendocs.sh
-rwxr-xr-x 1 dkg dkg  4735 2008-04-17 13:46 gnupload
-rw-r--r-- 1 dkg dkg  1292 2008-04-02 14:26 link-warning.h
[0 dkg at squeak git-gnutls]$ 

Any advice or pointers to better documentation would be welcome!

Regards,

    --dkg

[0] http://thread.gmane.org/gmane.comp.encryption.gpg.gnutls.devel/2908/focus=2909

  (the pipermail archives at http://lists.gnupg.org/pipermail/ are
  giving me a 403 forbidden error)

[1] http://tools.ietf.org/html/rfc4880#section-5.3

[2] http://trac.gnutls.org/cgi-bin/trac.cgi#SourceCode

-------------- next part --------------
A non-text attachment was scrubbed...
Name: functional_read_s2k-against-gnutls_with_ext_mpi.diff
Type: text/x-diff
Size: 1026 bytes
Desc: enable read_s2k() in src/opencdk/read-packet.c for gnutls_with_ext_mpi branch
URL: </pipermail/attachments/20080627/ccec94ad/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 826 bytes
Desc: not available
URL: </pipermail/attachments/20080627/ccec94ad/attachment.pgp>