[gnutls-dev] Fixing OpenPGP keyring import

[Ludovic Courtès]

Hi,

Timo Schulz <twoaday at gmx.net> writes:

> Ludovic Courtès wrote:
>
>> Yes, but my patch uses `CDK_DBTYPE_PK_DATA' because the data comes from
>> a user-provided buffer, not from a file.  In this case,
>> `cdk_keydb_new ()' just creates a temporary stream from the user buffer,
>> without leaving the opportunity set/clear that stream's armor flag.
>
> OK, I fixed it in the CVS. The backport is pretty easy and just two
> lines.

Ok, cool, this is good news!

(BTW, I'd appreciate a bit more documentation while you're at it.  :-))

> Sorry. It should be "if this is the only reason for the new code". IMHO
> the issue is fixed with the armor support for CDK_DBTYPE_DATA and the
> new cdk_keydb_new_from_stream() function.
>
> As I said, the backport is pretty easy. But I would suggest to think of
> a migration strategy because I fixed a lot of other stuff and GnuTLS
> would definitely benefit of the new code.

I guess it's up to Simon to decide whether to backport or to migrate.
It probably depends on the level of (in)compatibility between the
current and the new OpenCDK.

Thanks!

Ludovic.