[PATCH] efl: convert pinentry description to markup

[Bertrand Jacquin]

Hi

On Monday, February 15 2021 at 12:27:56 +0000, Damien Goutte-Gattat wrote:
> Hi,
> 
> On Sat, Feb 13, 2021 at 03:37:54PM +0000, Bertrand Jacquin wrote:
> >+      txt = elm_entry_utf8_to_markup(pinentry_utf8_to_local 
> >(pinentry->lc_ctype, pinentry->title));
> 
> Not familiar with EFL, but shouldn’t it be the other way around? If the 
> elm_entry_utf8_to_markup function expects UTF8 input (as the name 
> implies), calling it *after* pinentry_utf8_to_local doesn’t look right…

pinentry->description is inherited from SETDESC send by gpg-agent to
pinentry. SETDESC content is defined from i18n_localegettext() which
assume UTF-8 is used for encoding, however since this function a wrapper
around gettext(), the encoding of libgpg-error .po file is authoritative
here (which all are in git master).

Which means, indeed there is no need to perform pinentry_utf8_to_local()
at all since elm_entry_utf8_to_markup() is indeed expecting all input to
be UTF-8 which we have guaranteed.

Please find attached an updated patch, no change in behaviour.

Cheers,
Bertrand

-- 
Bertrand
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-efl-convert-pinentry-description-to-markup.patch
Type: text/x-diff
Size: 4335 bytes
Desc: not available
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20210216/52208d3a/attachment.patch>