[PATCH] efl: convert pinentry description to markup

Damien Goutte-Gattat dgouttegattat at incenp.org
Mon Feb 15 13:27:56 CET 2021


Hi,

On Sat, Feb 13, 2021 at 03:37:54PM +0000, Bertrand Jacquin wrote:
>+      txt = elm_entry_utf8_to_markup(pinentry_utf8_to_local 
>(pinentry->lc_ctype, pinentry->title));

Not familiar with EFL, but shouldn’t it be the other way around? If the 
elm_entry_utf8_to_markup function expects UTF8 input (as the name 
implies), calling it *after* pinentry_utf8_to_local doesn’t look right…

It seems to me that you should first convert to markup (which leaves the 
string in the original UTF-8 encoding), and *then* convert to the local 
encoding.

Cheers,

- Damien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20210215/160d97a1/attachment-0001.sig>


More information about the Gnupg-devel mailing list