[PATCH 3/5] gpg,tests: Add tests for the PGP trust model.

[Damien Goutte-Gattat]

On 07/19/2017 12:52 PM, Justus Winter wrote:
> Let me be the first to say:  Very cool :D

Thanks. :)


>> +;; Redefine GPG without --always-trust.
>> +(define GPG `(,(tool 'gpg)))
> 
> We should explicitly select the trust model here, because we may want to
> change the default trust model in the future.

That is done a little bit later by calling gpgconf to set the 
trust-model option:

   (let ((trust-model (gpg-config 'gpg "trust-model")))
     (trust-model::update "pgp"))


> Hehe >,< brutally, yes.  It also hard-codes a lot of knowledge about the
> internal state of GnuPG.  Why not move the common definitions to a
> separate file, and split this test into four?

That would probably be cleaner and more robust, indeed. OK, I will do 
that and re-submit the patchset.

Thanks for the comments.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: </pipermail/attachments/20170719/13bd301b/attachment-0001.sig>