[PATCH HEAD] i18n fixes

Ineiev ineiev at gnu.org
Sat Jan 7 16:06:34 CET 2017


Hello, Neal;

On Fri, Jan 06, 2017 at 11:47:46AM +0100, Neal H. Walfield wrote:
> 
> I tried to clean up the major issues about a month ago.

Thank you, it looks much better now.

> Would you be
> willing to have a look at tofu.c again and point out any serious
> issues.

Sometimes tofu_policy_str () is used in translated strings.  I think
a translated version should be used in such cases.

Lines 1630..1633,

          es_fprintf (fp, "  %s (", other_user_id);
          es_fprintf (fp, _("policy: %s"), tofu_policy_str (other_policy));
          es_fprintf (fp, ")\n");

may translate better if joint in a single message.

The ngettext on lines 3215..3228,

    (ngettext
     ("Warning: if you think you've seen more signatures "
      "by this key and user id, then this key might be a "
      "forgery!  Carefully examine the email address for small "
      "variations.  If the key is suspect, then use\n"
      "  %s\n"
      "to mark it as being bad.\n",
      "Warning: if you think you've seen more signatures "
      "by this key and these user ids, then this key might be a "
      "forgery!  Carefully examine the email addresses for small "
      "variations.  If the key is suspect, then use\n"
      "  %s\n"
      "to mark it as being bad.\n",
      strlist_length (user_id_list)),

makes little sense, the message uses no integer parameters.

> Also, I'm a bit confused about the issue with the "revoked" and
> "expired" strings.  They are used as a list of attributes.  What type
> of context do you want?

In GPG, "revoked" and "expired" may modify "signature", "binding",
"key" (and possibly more), their translations in many European
languages may have three different grammatical genders, and the form
of the adjective depends on the gender of the noun it modifies.
if the program uses _("revoked"), gettext has to substitute the same
form in all cases, so it's impossible to match different genders.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: </pipermail/attachments/20170107/c82220be/attachment.sig>


More information about the Gnupg-devel mailing list