[Help-gnutls] Re: [PATCH] fix gnutls guile detection

[Simon Josefsson]

Nix <nix at esperi.org.uk> writes:

> (I tried to send this to gnutls-dev@, but it doesn't allow posts from
> non-subscribers, and a fly-by-night patch such as this doesn't merit
> subscription.)

I'm using help-gnutls at gnu.org now, I believe it accept such posts.  We
should probably move gnutls-dev to gnu.org since their mailman
configuration seems slightly better in a few places.

> The configure script is substituting GUILE_LDFLAGS into LDFLAGS, when
> it's not an LDFLAGS replacement, it's a LIBS replacement. If you put it
> into LDFLAGS, you're likely to end up with a command line the moral
> equivalent of
>
> gcc -lguile -o conftest conftest.c
>
> which of course will fail to pick up references in conftest.c.
>
> We can't really rename GUILE_LDFLAGS here because it's part of guile,
> but we can certainly fix its use in the configure script.
>
> This trivial patch applies against both the gnutls_2_0_x branch and the head.

Ludovic, I can't judge this.  Can you take a look?  Feel free to check
your commit access by installing (together with a NEWS entry). :) It
should probably go into the 2.0.x branch as well?

/Simon

> 2007-09-29  Nix  <nix at esperi.org.uk>
>
> 	* configure.in: Substitute GUILE_LDFLAGS into LIBS, not LDFLAGS.
>
> Index: 2.0.1/configure.in
> ===================================================================
> --- 2.0.1.orig/configure.in	2007-09-17 10:13:36.000000000 +0100
> +++ 2.0.1/configure.in	2007-09-29 12:45:27.000000000 +0100
> @@ -312,14 +312,14 @@
>        GUILE_FLAGS
>  
>        save_CFLAGS="$CFLAGS"
> -      save_LDFLAGS="$LDFLAGS"
> +      save_LIBS="$LIBS"
>        CFLAGS="$CFLAGS $GUILE_CFLAGS"
> -      LDFLAGS="$LDFLAGS $GUILE_LDFLAGS"
> +      LIBS="$LIBS $GUILE_LDFLAGS"
>        AC_MSG_CHECKING([whether GNU Guile is recent enough])
>        AC_LINK_IFELSE(AC_LANG_CALL([], [scm_from_locale_string]),
>          [], [opt_guile_bindings=no])
>        CFLAGS="$save_CFLAGS"
> -      LDFLAGS="$save_LDFLAGS"
> +      LIBS="$save_LIBS"
>  
>        if test "x$opt_guile_bindings" = "xyes"; then
>          AC_MSG_RESULT([yes])