[gnutls-devel] GnuTLS | Refactor `_gnutls_buffer_pop_prefix*` (!2121)

[(Deprecated) Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2121 was reviewed by Sahana Prasad

--
  
Sahana Prasad started a new discussion on lib/str.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2121#note_3635702557

 > -
 > -	if (check && *data > buf->length - 1) {
 > +	if (buf->length < 1 || *data > buf->length - 1) {

isn't buf->length already decremented before returning in _gnutls_buffer_pop_uint8()? Do we need to have the -1 check here again? I think same thing happens in other prefix functions as well.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2121
You're receiving this email because of your account on gitlab.com. Unsubscribe from this thread: https://gitlab.com/-/namespace/17175643/sent_notifications/6-32vyoanl3i6vzy20xs6auo6zd-a84t7/unsubscribe | Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20260803/e2e1f3c4/attachment-0001.html>