[gnutls-devel] GnuTLS | tests: fix unset $SEED (!2089)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Thu Apr 9 15:08:48 CEST 2026



Ricardo M_ Correia created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2089

Project:Branches: wizeman/gnutls:fix-seed to gnutls/gnutls:master
Author:   Ricardo M_ Correia



<!-- Add a description of the new feature/bug fix. Reference any relevant bugs. -->
A test script was using a shell variable `$SEED` without setting it first. This led to `certtool` using a random seed value rather than the intended fixed seed, which in turn led to random (rare) failures when generating 2048-bit DSA keys during the test, since random DSA key generation does not always succeed.

Fixed the test by setting `$SEED` to the same fixed values that are set in `provable-privkey.sh`.

## Checklist
 * [X] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2089
You're receiving this email because of your account on gitlab.com. Unsubscribe from this thread: https://gitlab.com/-/sent_notifications/4-03wv2ythomm83mkire65v6hoc-a84t7/unsubscribe | Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20260409/2d1b5472/attachment-0001.html>


More information about the Gnutls-devel mailing list