[gnutls-devel] GnuTLS | pkcs11: try to initialize modules in thread-safe mode (!2014)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2014 was reviewed by Alexander Sosedkin

--
  
Alexander Sosedkin started a new discussion on tests/pkcs11/pkcs11-mock4.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2014#note_2735997828

 > +	CK_C_INITIALIZE_ARGS *init_args = args;
 > +
 > +	if (init_args->flags & CKF_OS_LOCKING_OK)

maybe get more specific, track whether it's the first or second initialization call and expect specific values of flags on each attempt? this way I'm worrying that the test might be overly forgiving

--
  
Alexander Sosedkin started a new discussion on lib/pkcs11.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2014#note_2735997863

 > +					NULL;
 > +	provider->init_args = args;
 > +	if (p11_kit_module_get_flags(module) & P11_KIT_MODULE_TRUSTED ||

should this call have error checking?

--
  
Alexander Sosedkin started a new discussion on lib/pkcs11.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2014#note_2735997880

 > +			gnutls_assert();
 > +			pkcs11_provider_deinit(&provider);
 > +			char *name = p11_kit_module_get_name(provider.module);

should this call have error checking? should it preface pkcs11_provider_deinit?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2014
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250908/1dc01ac0/attachment-0001.html>