[gnutls-devel] GnuTLS | lib/psk: Add gnutls_psk_allocate_{client, server}_credentials2 (!1939)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1939 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/libgnutls.map: https://gitlab.com/gnutls/gnutls/-/merge_requests/1939#note_2415754700

 > + local:
 > +	*;
 > +} GNUTLS_3_7_7;

```suggestion:-7+0
GNUTLS_3_8_10
{
 global:
	gnutls_psk_allocate_client_credentials2;
	gnutls_psk_allocate_server_credentials2;
 local:
	*;
} GNUTLS_3_8_6;
```

--
  
Daiki Ueno started a new discussion on lib/psk.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1939#note_2415754735

 > +	/* TLS 1.3 - Only SHA-256 and SHA-384 are allowed */
 > +	if (mac != GNUTLS_MAC_SHA256 && mac != GNUTLS_MAC_SHA384)
 > +		return gnutls_assert_val(GNUTLS_E_INVALID_REQUEST);

`*sc` is leaking here

--
  
Daiki Ueno started a new discussion on lib/psk.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1939#note_2415754749

 > +	 */
 > +	if (mac != GNUTLS_MAC_SHA256 && mac != GNUTLS_MAC_SHA384 &&
 > +	    mac != GNUTLS_MAC_NONE)

I couldn't find `GNUTLS_MAC_NONE` definition, where did it come from? There is `GNUTLS_MAC_UNKNOWN` though.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1939
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250325/81107b4f/attachment.html>