[gnutls-devel] GnuTLS | lib/psk: Add gnutls_psk_allocate_{client, server}_credentials2 (!1939)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1939 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/ext/pre_shared_key.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1939#note_2399262626

 >  			prf = pskcred->binder_algo;
 > +			if (prf)
 > +				mac = GNUTLS_MAC_NONE;

Do you mean `GNUTLS_MAC_UNKNOWN`, or `mac = prf->id`?

--
  
Daiki Ueno started a new discussion on lib/ext/pre_shared_key.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1939#note_2399262633

 >  	    gnutls_memcmp(binder_value, binder_recvd.data, binder_recvd.size)) {
 > +		if (mac == GNUTLS_MAC_SHA384) {
 > +			mac = GNUTLS_MAC_SHA256;

Setting the same value again?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1939
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250316/bb4af714/attachment.html>