[gnutls-devel] GnuTLS | Fix for 1724 (!1988)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1988 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on configure.ac: https://gitlab.com/gnutls/gnutls/-/merge_requests/1988#note_2626918492

 > +    AC_CHECK_DECL([Esys_SetCryptoCallbacks], [
 > +        AC_DEFINE([HAVE_ESYS_SETCRYPTOCALLBACKS], 1, [Define if Esys_SetCryptoCallbacks is available])
 > +    ], [], [[#include <tss2/tss2_esys.h>]])

Can't we simply use `AC_CHECK_FUNCS`?
```suggestion:-2+0
    AC_CHECK_FUNCS([Esys_SetCryptoCallbacks])
```

--
  
Daiki Ueno started a new discussion on lib/tpm2/callbacks/aes/aes_callbacks.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1988#note_2626918511

 >  #define GNUTLS_LIB_TPM2_AES_CALLBACKS_H
 >  
 > +#ifdef HAVE_ESYS_SETCRYPTOCALLBACKS

You might want to add an Automake conditional and exclude compilation of those *_callbacks.c at https://gitlab.com/gnutls/gnutls/-/blob/master/lib/Makefile.am?ref_type=heads#L140 something like:
```make
if ENABLE_TPM2
COBJECTS += tpm2/tpm2.c tpm2/tpm2.h tpm2/tpm2_esys.c
if NEED_ESYS_CRYPTO_CALLBACKS
COBJECTS += tpm2/callbacks/esys_crypto_callbacks.h tpm2/callbacks/esys_crypto_callbacks.c ...
endif
...
endif
```


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1988
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250714/6311cf52/attachment-0001.html>