[gnutls-devel] GnuTLS | Draft: x509: support encoding of ML-DSA private keys in CHOICE format (!1973)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 was reviewed by Alicja Kario (@mention me if you need reply)

--
  
Alicja Kario (@mention me if you need reply) started a new discussion on lib/x509/privkey_pkcs8.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2601200960

 > +	 * parse it manually */
 > +	if (raw_key->size == 34 && raw_key->data[0] == 0x80 &&
 > +	    raw_key->data[1] == 0x20) {

this is more on the level of a nit than an actual issue, but I think it would be nicer to check if the first byte is `0x80` as that indicates that this is the `[0]` context-specific implicit tag, and only then check for length, and reject it if it is wrong, with a more specific error message


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250703/b3f485bb/attachment-0001.html>