From gnutls-devel at lists.gnutls.org Tue Jul 1 16:39:24 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 01 Jul 2025 14:39:24 +0000 Subject: [gnutls-devel] GnuTLS | tests/tls13-early-data-neg2: avoid a small memory leak (!1969) In-Reply-To: References: Message-ID: Daiki Ueno started a new discussion on tests/tls13-early-data-neg2.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1969#note_2596816622 > > if (t < 2) { > /* get the session data size */ > + if (session_data.data) > + gnutls_free(session_data.data); I would prefer calling `gnutls_free` unconditionally without the check. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1969#note_2596816622 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Jul 1 16:43:08 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 01 Jul 2025 14:43:08 +0000 Subject: [gnutls-devel] GnuTLS | tests/tls13-early-data-neg2: avoid a small memory leak (!1969) In-Reply-To: References: Message-ID: Daiki Ueno started a new discussion on tests/tls13-early-data-neg2.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1969#note_2596830985 > fail("client: unexpected non-zero value of max_early_data_size = %d\n", > (int)gnutls_record_get_max_early_data_size( > session)); > - if (gnutls_record_send_early_data( > - session, EARLY_MSG, > - sizeof(EARLY_MSG)) >= 0) > + do { > + ret = gnutls_record_send_early_data( > + session, EARLY_MSG, > + sizeof(EARLY_MSG)); > + } while (ret == GNUTLS_E_AGAIN || I wonder if this test could be rewritten without fork, so such check would be not necessary in the first place. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1969#note_2596830985 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Jul 1 16:44:30 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 01 Jul 2025 14:44:30 +0000 Subject: [gnutls-devel] GnuTLS | src/danetool.c: Free str on error to avoid memory leak (!1963) In-Reply-To: References: Message-ID: All discussions on merge request !1963 were resolved by Daiki Ueno https://gitlab.com/gnutls/gnutls/-/merge_requests/1963 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1963 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Jul 1 16:44:15 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 01 Jul 2025 14:44:15 +0000 Subject: [gnutls-devel] GnuTLS | src/danetool.c: Free str on error to avoid memory leak (!1963) In-Reply-To: References: Message-ID: Merge request !1963 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1963 Project:Branches: JiashengJiang/gnutls:patch13 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Jul 1 16:44:34 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 01 Jul 2025 14:44:34 +0000 Subject: [gnutls-devel] GnuTLS | src/danetool.c: Free str on error to avoid memory leak (!1963) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1963#note_2596837838 Thank you! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1963#note_2596837838 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Jul 1 16:45:12 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 01 Jul 2025 14:45:12 +0000 Subject: [gnutls-devel] GnuTLS | src/danetool.c: Free str on error to avoid memory leak (!1963) In-Reply-To: References: Message-ID: Merge request !1963 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1963 Project:Branches: JiashengJiang/gnutls:patch13 to gnutls/gnutls:master Author: Jiasheng Jiang -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1963 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Jul 1 16:48:06 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 01 Jul 2025 14:48:06 +0000 Subject: [gnutls-devel] GnuTLS | doc: fix typo in docs about system profile fallback (!1971) References: Message-ID: Daniel P_ Berrang? created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1971 Project:Branches: berrange/gnutls:keyword-typo to gnutls/gnutls:master Author: Daniel P_ Berrang? Docs for the system profile fallback syntax accidentally repeated the "@" marker before each keyword. The "@" marker only indicates the start of the profile field, and individual names are merely separated by a comma, per the impl in 6b6d9dd44e. Fixes 6f425b0fd7d860e9d78b7ba0d9c4d3165d824d7c ## Checklist * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1971 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Jul 1 16:54:16 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 01 Jul 2025 14:54:16 +0000 Subject: [gnutls-devel] GnuTLS | doc: fix typo in docs about system profile fallback (!1971) In-Reply-To: References: Message-ID: Merge request !1971 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1971 Project:Branches: berrange/gnutls:keyword-typo to gnutls/gnutls:master Author: Daniel P_ Berrang? Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Jul 1 16:54:25 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 01 Jul 2025 14:54:25 +0000 Subject: [gnutls-devel] GnuTLS | doc: fix typo in docs about system profile fallback (!1971) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1971#note_2596885556 Thank you! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1971#note_2596885556 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Tue Jul 1 16:54:56 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Tue, 01 Jul 2025 14:54:56 +0000 Subject: [gnutls-devel] GnuTLS | doc: fix typo in docs about system profile fallback (!1971) In-Reply-To: References: Message-ID: Merge request !1971 was set to auto-merge by Daiki Ueno Merge request url: https://gitlab.com/gnutls/gnutls/-/merge_requests/1971 Project:Branches: berrange/gnutls:keyword-typo to gnutls/gnutls:master Author: Daniel P_ Berrang? Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Jul 2 11:44:50 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 09:44:50 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 Project:Branches: dueno/gnutls:wip/dueno/mldsa-followup2 to gnutls/gnutls:master Author: Daiki Ueno This extends the acceptable formats of ML-DSA private keys to the three formats defined in draft-ietf-lamps-dilithium-certificates-12, section 6, namely: "seed", "expandedKey", and "both". The legacy format compatible with liboqs/oqsprovider is still accepted and the default output format for now. ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [x] Code modified for feature * [x] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Jul 2 12:09:56 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 10:09:56 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) started a new discussion on lib/x509/privkey_pkcs8.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2598449985 > } > } > > + /* Append an empty publicKey field. > + */ > + result = asn1_write_value(*pkey_info, "publicKey", NULL, 0); I don't think it's mandatory to include it... I'm pretty sure that the test vectors don't have it... -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2598449985 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Jul 2 12:15:39 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 10:15:39 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) started a new discussion on lib/gnutls.asn: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2598466472 > privkey OCTET STRING > } > > +-- Legacy private key format defined in > +-- draft-ietf-lamps-dilithium-certificates-04, section 6 it's not that either, as the liboqs format puts both the private key and public key in the `privateKey` field? Or will gnutls allow a fifth format? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2598466472 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Jul 2 12:17:11 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 10:17:11 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2598470657 I do see test keys, but how do we verify that all three result in the same expanded key after loading? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2598470657 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Jul 2 12:59:20 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 10:59:20 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Daiki Ueno commented on a discussion on lib/x509/privkey_pkcs8.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2598574402 > } > } > > + /* Append an empty publicKey field. > + */ > + result = asn1_write_value(*pkey_info, "publicKey", NULL, 0); This does not affect the output format, but just indicates that the "publicKey" field is empty. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2598574402 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Jul 2 13:01:08 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 11:01:08 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Daiki Ueno commented on a discussion on lib/gnutls.asn: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2598578440 > privkey OCTET STRING > } > > +-- Legacy private key format defined in > +-- draft-ietf-lamps-dilithium-certificates-04, section 6 That depends on whether the "version" field is 0 or 1. If 0, we used to concatenate a private key and a public key; if it is 1, a public key was stored in a separate field. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2598578440 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Wed Jul 2 13:01:08 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 11:01:08 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: All discussions on merge request !1972 were resolved by Daiki Ueno https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 01:51:39 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 23:51:39 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Daiki Ueno commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2600059541 Oh, I forgot to commit the changes to tests/mldsa.sh. Should now be there. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2600059541 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 01:52:48 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 23:52:48 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Reassigned merge request 1972 https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 Daiki Ueno was added as an assignee. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 01:53:05 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 23:53:05 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) was added as a reviewer. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 01:53:16 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Wed, 02 Jul 2025 23:53:16 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Milestone changed to Release of GnuTLS 3.8.10 (Feb 7, 2025?Jul 31, 2025) ( https://gitlab.com/gnutls/gnutls/-/milestones/48 ) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 02:07:35 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 00:07:35 +0000 Subject: [gnutls-devel] GnuTLS | doc: fix typo in docs about system profile fallback (!1971) In-Reply-To: References: Message-ID: Merge request !1971 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1971 Project:Branches: berrange/gnutls:keyword-typo to gnutls/gnutls:master Author: Daniel P_ Berrang? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1971 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 09:11:12 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 07:11:12 +0000 Subject: [gnutls-devel] GnuTLS | Draft: pubkey: fix byte/bit confusion in public key sizes of ML-DSA (!1973) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 Project:Branches: dueno/gnutls:wip/dueno/mldsa-followup3 to gnutls/gnutls:master Author: Daiki Ueno This is an encoding counterpart of !1972. ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 09:17:18 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 07:17:18 +0000 Subject: [gnutls-devel] GnuTLS | Draft: x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Daiki Ueno marked merge request !1973 as draft -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 12:42:55 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 10:42:55 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2601164994 LGTM -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972#note_2601164994 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 12:42:54 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 10:42:54 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Merge request !1972 was approved by Alicja Kario (@mention me if you need reply) Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 Project:Branches: dueno/gnutls:wip/dueno/mldsa-followup2 to gnutls/gnutls:master Author: Daiki Ueno Assignee: Daiki Ueno Reviewer: Alicja Kario (@mention me if you need reply) -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 12:58:12 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 10:58:12 +0000 Subject: [gnutls-devel] GnuTLS | Draft: x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 was reviewed by Alicja Kario (@mention me if you need reply) -- Alicja Kario (@mention me if you need reply) started a new discussion on lib/x509/privkey_pkcs8.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2601200960 > + * parse it manually */ > + if (raw_key->size == 34 && raw_key->data[0] == 0x80 && > + raw_key->data[1] == 0x20) { this is more on the level of a nit than an actual issue, but I think it would be nicer to check if the first byte is `0x80` as that indicates that this is the `[0]` context-specific implicit tag, and only then check for length, and reject it if it is wrong, with a more specific error message -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 12:58:13 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 10:58:13 +0000 Subject: [gnutls-devel] GnuTLS | Draft: x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2601201014 LGTM, with the exception of that one nit I haven't checked if the test vectors match the drafts or if it interoperates with openssl though -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2601201014 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 12:58:12 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 10:58:12 +0000 Subject: [gnutls-devel] GnuTLS | Draft: x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Merge request !1973 was approved by Alicja Kario (@mention me if you need reply) Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 Project:Branches: dueno/gnutls:wip/dueno/mldsa-followup3 to gnutls/gnutls:master Author: Daiki Ueno Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 22:16:43 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 20:16:43 +0000 Subject: [gnutls-devel] GnuTLS | Add a way to show the default trust store configuration (#1720) References: Message-ID: Sam Morris created an issue: https://gitlab.com/gnutls/gnutls/-/issues/1720 ## Description of the feature: It would be useful if `gnutls-cli --list-config` would show what trust store option GnuTLS was configured with. Something like: ``` default-trust-store-pkcs11: pkcs11: ``` or ``` default-trust-store-file: /etc/ssl/certs/ca-certificates.crt ``` and so on. ## Applications that this feature may be relevant to: User-facing feature. When I am configuring systems it's useful to be able to check how various TLS libraries are configured. ## Is this feature implemented in other libraries (and which) N/A -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1720 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 22:51:56 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 20:51:56 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: All discussions on merge request !1972 were resolved by Daiki Ueno https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Thu Jul 3 23:14:21 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Thu, 03 Jul 2025 21:14:21 +0000 Subject: [gnutls-devel] GnuTLS | x509: support decoding of ML-DSA private keys in CHOICE format (!1972) In-Reply-To: References: Message-ID: Merge request !1972 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 Project:Branches: dueno/gnutls:wip/dueno/mldsa-followup2 to gnutls/gnutls:master Author: Daiki Ueno Assignee: Daiki Ueno Reviewer: Alicja Kario (@mention me if you need reply) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1972 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 05:51:30 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 03:51:30 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Daiki Ueno marked merge request !1973 as ready -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 05:52:40 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 03:52:40 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Daiki Ueno commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2602647220 Added some roundtrip tests -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2602647220 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 06:37:58 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 04:37:58 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: All discussions on merge request !1973 were resolved by Daiki Ueno https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 06:37:57 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 04:37:57 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Daiki Ueno commented on a discussion on lib/x509/privkey_pkcs8.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2602678535 > return ret; > } > > +static int decode_ml_dsa_inner_private_key(const gnutls_datum_t *raw_key, > + size_t raw_pub_size, > + size_t raw_priv_size, > + gnutls_x509_privkey_t pkey) > +{ > + int ret; > + asn1_node inner_asn = NULL; > + > + /* libtasn1 doesn't support encoding instructions in CHOICE, > + * parse it manually */ > + if (raw_key->size == 34 && raw_key->data[0] == 0x80 && > + raw_key->data[1] == 0x20) { I'm afraid that would make the control flow complicated as the other alternatives in the CHOICE is handled in the `else` branch. I'd leave it as is. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2602678535 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 08:39:31 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 06:39:31 +0000 Subject: [gnutls-devel] GnuTLS | algorithms: assign hash strength to ML-DSA signature algorithms (!1974) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1974 Project:Branches: dueno/gnutls:wip/dueno/mldsa-tls-fixes to gnutls/gnutls:master Author: Daiki Ueno The _gnutls_sign_get_hash_strength function previously returned 0 for ML-DSA algorithms, preventing the security level check in certificate signatures. This assigns the collision strength for commitment hashes, as defined in FIPS 204, section 4, table 1. ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1974 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 08:57:33 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 06:57:33 +0000 Subject: [gnutls-devel] GnuTLS | algorithms: assign hash strength to ML-DSA signature algorithms (!1974) In-Reply-To: References: Message-ID: Reassigned merge request 1974 https://gitlab.com/gnutls/gnutls/-/merge_requests/1974 Daiki Ueno was added as an assignee. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1974 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 08:57:32 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 06:57:32 +0000 Subject: [gnutls-devel] GnuTLS | algorithms: assign hash strength to ML-DSA signature algorithms (!1974) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) was added as a reviewer. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1974 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 08:57:55 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 06:57:55 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) was added as a reviewer. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 08:57:58 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 06:57:58 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Reassigned merge request 1973 https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 Daiki Ueno was added as an assignee. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 10:39:15 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 08:39:15 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Merge request !1973 was approved by Zolt?n Fridrich Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 Project:Branches: dueno/gnutls:wip/dueno/mldsa-followup3 to gnutls/gnutls:master Author: Daiki Ueno Assignee: Daiki Ueno Reviewer: Alicja Kario (@mention me if you need reply) -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 10:39:41 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 08:39:41 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Zolt?n Fridrich commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603041167 Looks nice. No mistakes spotted. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603041167 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 10:52:53 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 08:52:53 +0000 Subject: [gnutls-devel] GnuTLS | algorithms: assign hash strength to ML-DSA signature algorithms (!1974) In-Reply-To: References: Message-ID: Merge request !1974 was approved by Alicja Kario (@mention me if you need reply) Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1974 Project:Branches: dueno/gnutls:wip/dueno/mldsa-tls-fixes to gnutls/gnutls:master Author: Daiki Ueno Assignee: Daiki Ueno Reviewer: Alicja Kario (@mention me if you need reply) -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 10:52:54 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 08:52:54 +0000 Subject: [gnutls-devel] GnuTLS | algorithms: assign hash strength to ML-DSA signature algorithms (!1974) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1974#note_2603066655 LGTM -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1974#note_2603066655 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 11:02:51 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 09:02:51 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 was reviewed by Alexander Sosedkin -- Alexander Sosedkin started a new discussion on lib/x509/privkey_pkcs8.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603089825 > + > + if (flags & GNUTLS_PKCS_MLDSA_SEED) > + format |= 1 << 0; maybe use enum values instead of magic constants? -- Alexander Sosedkin started a new discussion on lib/x509/privkey_pkcs8.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603089835 > + ML_DSA_PRIVKEY_FORMAT_SEED, > + ML_DSA_PRIVKEY_FORMAT_EXPANDED, > + ML_DSA_PRIVKEY_FORMAT_BOTH I'd find verifying `ML_DSA_PRIVKEY_FORMAT_BOTH == ML_DSA_PRIVKEY_FORMAT_EXPANDED | ML_DSA_PRIVKEY_FORMAT_SEED` easier if the numbers were spelled out. -- Alexander Sosedkin started a new discussion on src/certtool-options.json: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603089842 > + "long-option": "key-format", > + "description": "Specify the key format to use on key generation", > + "detail": "This option can be combined with --generate-privkey, to specify\nthe key format to be generated, when the key type is ML-DSA. Valid options are, 'seed', 'expanded', and 'both'.", Should it error out when the key type is not ML-DSA? Just to reduce confusion and to not support ignoring it when it's not. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 11:03:08 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 09:03:08 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Alicja Kario (@mention me if you need reply) commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603090423 still looks good :smile: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603090423 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 11:16:55 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 09:16:55 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Daiki Ueno commented on a discussion on lib/x509/privkey_pkcs8.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603142256 > #define PEM_PKCS8 "ENCRYPTED PRIVATE KEY" > #define PEM_UNENCRYPTED_PKCS8 "PRIVATE KEY" > > +typedef enum ml_dsa_privkey_format_t { > + ML_DSA_PRIVKEY_FORMAT_UNKNOWN = 0, > + ML_DSA_PRIVKEY_FORMAT_SEED, > + ML_DSA_PRIVKEY_FORMAT_EXPANDED, > + ML_DSA_PRIVKEY_FORMAT_BOTH Good idea, rewrote in that way. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603142256 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 11:19:11 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 09:19:11 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: All discussions on merge request !1973 were resolved by Daiki Ueno https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 11:19:14 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 09:19:14 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Daiki Ueno commented on a discussion on src/certtool-options.json: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603147005 > "detail": "This option can be combined with --generate-privkey, to specify\nthe key type to be generated. Valid options are, 'rsa', 'rsa-pss', 'rsa-oaep', 'dsa', 'ecdsa', 'ed25519, 'ed448', 'x25519', and 'x448'.'.\nWhen combined with certificate generation it can be used to specify an\nRSA-PSS certificate when an RSA key is given.", > "argument-type": "string" > }, > + { > + "long-option": "key-format", > + "description": "Specify the key format to use on key generation", > + "detail": "This option can be combined with --generate-privkey, to specify\nthe key format to be generated, when the key type is ML-DSA. Valid options are, 'seed', 'expanded', and 'both'.", It would be too complicated to implement, as in some cases (e.g., `certtool -k`) the key type is known only after decoding the key itself. I'd leave it as-is, as most of the other options that don't take effect are simply ignored. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973#note_2603147005 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 11:35:56 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 09:35:56 +0000 Subject: [gnutls-devel] GnuTLS | algorithms: assign hash strength to ML-DSA signature algorithms (!1974) In-Reply-To: References: Message-ID: Merge request !1974 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1974 Project:Branches: dueno/gnutls:wip/dueno/mldsa-tls-fixes to gnutls/gnutls:master Author: Daiki Ueno Assignee: Daiki Ueno Reviewer: Alicja Kario (@mention me if you need reply) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1974 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 13:49:04 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 11:49:04 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Merge request !1973 was approved by Alexander Sosedkin Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 Project:Branches: dueno/gnutls:wip/dueno/mldsa-followup3 to gnutls/gnutls:master Author: Daiki Ueno Assignee: Daiki Ueno Reviewer: Alicja Kario (@mention me if you need reply) -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Fri Jul 4 14:13:18 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Fri, 04 Jul 2025 12:13:18 +0000 Subject: [gnutls-devel] GnuTLS | x509: support encoding of ML-DSA private keys in CHOICE format (!1973) In-Reply-To: References: Message-ID: Merge request !1973 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 Project:Branches: dueno/gnutls:wip/dueno/mldsa-followup3 to gnutls/gnutls:master Author: Daiki Ueno Assignee: Daiki Ueno Reviewer: Alicja Kario (@mention me if you need reply) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1973 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:01:11 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:01:11 +0000 Subject: [gnutls-devel] GnuTLS | Minor build fixes for pkcs11-provider (!1975) In-Reply-To: References: Message-ID: Zolt?n Fridrich was added as a reviewer. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1975 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:01:13 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:01:13 +0000 Subject: [gnutls-devel] GnuTLS | Minor build fixes for pkcs11-provider (!1975) References: Message-ID: Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1975 Project:Branches: dueno/gnutls:wip/dueno/pkcs11-provider-fixes to gnutls/gnutls:master Author: Daiki Ueno Reviewer: Zolt?n Fridrich * build: fix build with --with-included-libtasn1 As libminitasn1.la is always built a static library, linking it twice makes linking fail because of duplicated symbols. * pkcs11: stop including The header is unused and causing compile error on macOS homebrew: ``` In file included from p11_pk.c:32: /opt/homebrew/Cellar/nettle/3.10.2/include/nettle/bignum.h:50:11: fatal error: 'gmp.h' file not found # include ^~~~~~~ 1 error generated. ``` ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1975 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:47:17 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:47:17 +0000 Subject: [gnutls-devel] GnuTLS | src/common.c: Move gnutls_free() out of out lable to avoid double free (!1966) In-Reply-To: References: Message-ID: Merge request !1966 was closed by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1966 Project:Branches: JiashengJiang/gnutls:patch14 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1966 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:47:30 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:47:30 +0000 Subject: [gnutls-devel] GnuTLS | src/common.c: Move gnutls_free() out of out lable to avoid double free (!1966) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1966#note_2604423354 Closing as this seems like a non-issue. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1966#note_2604423354 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:48:51 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:48:51 +0000 Subject: [gnutls-devel] GnuTLS | tests/x509-cert-callback.c: Free p and certs on error to avoid memory leak (!1960) In-Reply-To: References: Message-ID: Merge request !1960 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1960 Project:Branches: JiashengJiang/gnutls:patch10 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:49:10 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:49:10 +0000 Subject: [gnutls-devel] GnuTLS | tests/x509-cert-callback.c: Free p and certs on error to avoid memory leak (!1960) In-Reply-To: References: Message-ID: Merge request !1960 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1960 Project:Branches: JiashengJiang/gnutls:patch10 to gnutls/gnutls:master Author: Jiasheng Jiang -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1960 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:49:58 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:49:58 +0000 Subject: [gnutls-devel] GnuTLS | tests/x509-cert-callback-ocsp.c: Free p and certs on error to avoid memory leak (!1958) In-Reply-To: References: Message-ID: Merge request !1958 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1958 Project:Branches: JiashengJiang/gnutls:patch8 to gnutls/gnutls:master Author: Jiasheng Jiang -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1958 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:49:48 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:49:48 +0000 Subject: [gnutls-devel] GnuTLS | tests/x509-cert-callback-ocsp.c: Free p and certs on error to avoid memory leak (!1958) In-Reply-To: References: Message-ID: Merge request !1958 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1958 Project:Branches: JiashengJiang/gnutls:patch8 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:52:03 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:52:03 +0000 Subject: [gnutls-devel] GnuTLS | lib/ext/srp.c: Add gnutls_free() to avoid memory leak (!1956) In-Reply-To: References: Message-ID: Daiki Ueno started a new discussion on lib/ext/srp.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1956#note_2604424109 > > priv->password = gnutls_strdup(cred->password); > if (priv->password == NULL) { > + gnutls_free(priv->username); > gnutls_assert(); Not a fault of this MR, but shouldn't we also set `ret` here (e.g., `GNUTLS_E_MEMORY_ERROR`)? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1956#note_2604424109 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:54:27 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:54:27 +0000 Subject: [gnutls-devel] GnuTLS | lib/x509/x509_ext.c: Add gnutls_free() to avoid memory leak (!1954) In-Reply-To: References: Message-ID: Merge request !1954 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1954 Project:Branches: JiashengJiang/gnutls:patch4 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:55:12 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:55:12 +0000 Subject: [gnutls-devel] GnuTLS | lib/x509/x509_ext.c: Add gnutls_free() to avoid memory leak (!1954) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1954#note_2604424677 LGTM, thanks! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1954#note_2604424677 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:55:20 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:55:20 +0000 Subject: [gnutls-devel] GnuTLS | lib/x509/x509_ext.c: Add gnutls_free() to avoid memory leak (!1954) In-Reply-To: References: Message-ID: Merge request !1954 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1954 Project:Branches: JiashengJiang/gnutls:patch4 to gnutls/gnutls:master Author: Jiasheng Jiang -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1954 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:56:38 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:56:38 +0000 Subject: [gnutls-devel] GnuTLS | lib/hello_ext.c: Add gnutls_free() to avoid memory leak (!1955) In-Reply-To: References: Message-ID: Merge request !1955 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1955 Project:Branches: JiashengJiang/gnutls:patch5 to gnutls/gnutls:master Author: Jiasheng Jiang -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1955 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sat Jul 5 02:56:27 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sat, 05 Jul 2025 00:56:27 +0000 Subject: [gnutls-devel] GnuTLS | lib/hello_ext.c: Add gnutls_free() to avoid memory leak (!1955) In-Reply-To: References: Message-ID: Merge request !1955 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1955 Project:Branches: JiashengJiang/gnutls:patch5 to gnutls/gnutls:master Author: Jiasheng Jiang Assignees: Reviewers: -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Sun Jul 6 17:33:50 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 06 Jul 2025 15:33:50 +0000 Subject: [gnutls-devel] GnuTLS | Expose HPKE through abstract key API [BASE+PSK] (!1976) References: Message-ID: David Dudas created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1976 Project:Branches: d-Dudas/gnutls:dev/ddudas/hpke to gnutls/gnutls:master Author: David Dudas * Porting HPKE - a new adaptation of !1749 by @poenix * Expose HPKE through abstract key API - currently just base + psk. ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [x] Code modified for feature * [x] Test suite updated with functionality tests * [x] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [x] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1976 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 01:10:58 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 06 Jul 2025 23:10:58 +0000 Subject: [gnutls-devel] GnuTLS | Add a way to show the default trust store configuration (#1720) In-Reply-To: References: Message-ID: Milestone changed to Release of GnuTLS 3.8.10 (Feb 7, 2025?Jul 31, 2025) ( https://gitlab.com/gnutls/gnutls/-/milestones/48 ) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1720 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 01:10:54 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 06 Jul 2025 23:10:54 +0000 Subject: [gnutls-devel] GnuTLS | Add a way to show the default trust store configuration (#1720) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/issues/1720#note_2606447439 Thank you for the suggestion; that makes sense to me (and would be trivial to implement). -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1720#note_2606447439 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 01:50:24 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Sun, 06 Jul 2025 23:50:24 +0000 Subject: [gnutls-devel] GnuTLS | Expose HPKE through abstract key API [BASE+PSK] (!1976) In-Reply-To: References: Message-ID: Daiki Ueno started a new discussion on lib/includes/gnutls/abstract.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1976#note_2606457953 > gnutls_certificate_print_formats_t format, > gnutls_datum_t *out); > > +int gnutls_privkey_encap(gnutls_pubkey_t pkR, gnutls_datum_t psk, > + gnutls_hpke_mode_t mode, gnutls_pubkey_t *pkE, Although this is suggested in the original issue, I would not hard-wire this API to HPKE, now that we also have ML-KEM. Perhaps `mode` could be turned into a flag, e.g., adding a `gnutls_pk_encapsulate_flags_t`? PSK might deserve a new API function though. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1976#note_2606457953 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 09:13:22 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 07 Jul 2025 07:13:22 +0000 Subject: [gnutls-devel] GnuTLS | Minor build fixes for pkcs11-provider (!1975) In-Reply-To: References: Message-ID: Merge request !1975 was approved by Zolt?n Fridrich Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1975 Project:Branches: dueno/gnutls:wip/dueno/pkcs11-provider-fixes to gnutls/gnutls:master Author: Daiki Ueno Assignees: Reviewer: Zolt?n Fridrich -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 09:14:18 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 07 Jul 2025 07:14:18 +0000 Subject: [gnutls-devel] GnuTLS | Minor build fixes for pkcs11-provider (!1975) In-Reply-To: References: Message-ID: Zolt?n Fridrich commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1975#note_2607179250 Thanks for spotting these. Looks good. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1975#note_2607179250 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 09:44:13 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 07 Jul 2025 07:44:13 +0000 Subject: [gnutls-devel] GnuTLS | Minor build fixes for pkcs11-provider (!1975) In-Reply-To: References: Message-ID: Merge request !1975 was merged Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1975 Project:Branches: dueno/gnutls:wip/dueno/pkcs11-provider-fixes to gnutls/gnutls:master Author: Daiki Ueno Reviewer: Zolt?n Fridrich -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1975 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 10:10:48 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 07 Jul 2025 08:10:48 +0000 Subject: [gnutls-devel] GnuTLS | Add documentation for the pkcs#11-provider (!1977) In-Reply-To: References: Message-ID: Reassigned merge request 1977 https://gitlab.com/gnutls/gnutls/-/merge_requests/1977 Zolt?n Fridrich was added as an assignee. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1977 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 10:10:50 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 07 Jul 2025 08:10:50 +0000 Subject: [gnutls-devel] GnuTLS | Add documentation for the pkcs#11-provider (!1977) References: Message-ID: Zolt?n Fridrich created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1977 Project:Branches: ZoltanFridrich/gnutls:zfridric_devel to gnutls/gnutls:master Author: Zolt?n Fridrich Assignee: Zolt?n Fridrich Reviewer: Daiki Ueno * Add NEWS entry for the PKCS#11 provider Signed-off-by: Zoltan Fridrich * Add documentation for the pkcs#11-provider Signed-off-by: Zoltan Fridrich ## Checklist * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1977 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 10:10:48 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 07 Jul 2025 08:10:48 +0000 Subject: [gnutls-devel] GnuTLS | Add documentation for the pkcs#11-provider (!1977) In-Reply-To: References: Message-ID: Daiki Ueno was added as a reviewer. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1977 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 10:48:03 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 07 Jul 2025 08:48:03 +0000 Subject: [gnutls-devel] GnuTLS | Add documentation for the pkcs#11-provider (!1977) In-Reply-To: References: Message-ID: Merge request !1977 was approved by Daiki Ueno Merge request URL: https://gitlab.com/gnutls/gnutls/-/merge_requests/1977 Project:Branches: ZoltanFridrich/gnutls:zfridric_devel to gnutls/gnutls:master Author: Zolt?n Fridrich Assignee: Zolt?n Fridrich Reviewer: Daiki Ueno -- You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 10:48:11 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 07 Jul 2025 08:48:11 +0000 Subject: [gnutls-devel] GnuTLS | Add documentation for the pkcs#11-provider (!1977) In-Reply-To: References: Message-ID: Daiki Ueno commented: https://gitlab.com/gnutls/gnutls/-/merge_requests/1977#note_2607597927 Thank you! -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1977#note_2607597927 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: From gnutls-devel at lists.gnutls.org Mon Jul 7 12:17:07 2025 From: gnutls-devel at lists.gnutls.org (Read-only notification of GnuTLS library development activities) Date: Mon, 07 Jul 2025 10:17:07 +0000 Subject: [gnutls-devel] Guile-GnuTLS | 32bit time_t fixes. (!41) In-Reply-To: References: Message-ID: Dariqq commented: https://gitlab.com/gnutls/guile/-/merge_requests/41#note_2607826173 Hi @jas, What do you think of this generally? I am happy to make adjustments but I am not a fan of the tests failing when the platform cannot handle 64bit time_t -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/guile/-/merge_requests/41#note_2607826173 You're receiving this email because of your account on gitlab.com. -------------- next part -------------- An HTML attachment was scrubbed... URL: