[gnutls-devel] GnuTLS | Add MLKEM-1024 and SecP384r1MLKEM1024. (!1919)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1919 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/algorithms/groups.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1919#note_2281863010

 > +	  .id = GNUTLS_GROUP_EXP_SECP384R1, GNUTLS_GROUP_EXP_MLKEM1024,
 > +		   GNUTLS_GROUP_INVALID },
 > +	  .tls_id = 0x11ED },

Notice the separate `.id` and `.ids` fields in this structure, where the former assigns a unique ID for this key share group, while the latter specifies the subgroups compositing this hybrid group. The correct entry should look like:

```suggestion:-3+0
	{ .name = "SECP384R1-MLKEM1024",
	  .id = GNUTLS_GROUP_EXP_SECP384R1_MLKEM1024,
	  .ids = { GNUTLS_GROUP_SECP384R1, GNUTLS_GROUP_EXP_MLKEM1024,
		   GNUTLS_GROUP_INVALID },
	  .tls_id = 0x11ED },
```


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1919
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250105/7bdf7c5e/attachment.html>