[gnutls-devel] GnuTLS | Improve 0-RTT handling in gnutls-serv/gnutls-cli (!1936)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1936 was reviewed by Sahil Siddiq

--
  
Sahil Siddiq started a new discussion on src/cli.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1936#note_2350109730

 >  			    ((gnutls_session_get_flags(hd->session) &
 >  			      GNUTLS_SFLAGS_SESSION_TICKET))) {
 > +				max_early_data_size =

The value of `max_early_data_size` is set here in the session due to the [call](https://gitlab.com/gnutls/gnutls/-/blob/master/src/cli.c#L1004) to gnutls_session_get_data2().

`max_early_data_size` and `hd` are then passed to socket_open_int() which in turn calls gnutls_record_set_max_early_data_size().

In the implementation of gnutls_record_set_max_early_data_size(), we are simply setting `session->security_parameters.max_early_data_size` to "size". Given that "size" originally came from the same session parameter in gnutls_record_get_max_early_data_size(), this call isn't required in socket.c, right?

--
  
Sahil Siddiq started a new discussion on src/socket.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1936#note_2350109732

 >  		if (hd->session) {
 >  			if (hd->edata.data) {
 > +				ret = gnutls_record_set_max_early_data_size(

`hd->session->security_parameters.max_early_data_size` should already by set to `max_early_data_size` due to the call to gnutls_session_get_data2() in cli.c


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1936
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20250216/e23b00bc/attachment-0001.html>