[gnutls-devel] GnuTLS | hash: return error if gnutls_hash is called after squeeze (!1885)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Wed Oct 16 08:59:40 CEST 2024



Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1885

Project:Branches: dueno/gnutls:wip/dueno/hash-after-squeeze to gnutls/gnutls:master
Author:   Daiki Ueno




<!-- Add a description of the new feature/bug fix. Reference any relevant bugs. -->

* hash: return error if gnutls_hash is called after squeeze

Previously, when gnutls_hash is called after gnutls_hash_squeeze, it
hits an assertion failure in nettle:
```
  sha3.c:76: _nettle_sha3_update: Assertion `pos < block_size' failed.
```
This adds an internal function to check whether the hash context has
already been finalized with squeezing and in that case errors out.

Fixes: #1592 

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1885
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20241016/9851a922/attachment.html>


More information about the Gnutls-devel mailing list