[gnutls-devel] GnuTLS | build: fix confusions of libtasn1 errors and GnuTLS errors (!1834)

[Read-only notification of GnuTLS library development activities]

Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1834

Project:Branches: dueno/gnutls:wip/dueno/error-asn1 to gnutls/gnutls:master
Author:   Daiki Ueno




<!-- Add a description of the new feature/bug fix. Reference any relevant bugs. -->

* build: fix confusions of libtasn1 errors and GnuTLS errors

libtasn1 error codes returned from asn1_{read,write}_value are always
positive. Check against ASN1_SUCCESS or convert them first with
_gnutls_asn2err.

Signed-off-by: Daiki Ueno <ueno at gnu.org>

* _gnutls_asn2err: accept ASN1_SUCCESS

This enables to unconditionally wrap calls to libtasn1 functions which
return error codes, like `_gnutls_asn2err(asn1_read_value(...))`.

Signed-off-by: Daiki Ueno <ueno at gnu.org>

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1834
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20240505/b5fa2bd9/attachment.html>