[gnutls-devel] GnuTLS | Fixed DHE params output in gnutls-cli-debug (!1822)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Sat Mar 16 16:39:19 CET 2024

Ramesh Adhikari created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1822

Project:Branches: SilentSobs/gnutls:dhe-params-stdout to gnutls/gnutls:master
Author:   Ramesh Adhikari

This commit addresses an issue where gnutls-cli-debug was emitting Diffie-Hellman Ephemeral (DHE) parameters to a statically-named file (debug-dh.out) when run with the --verbose option. This behavior posed a potential security risk, as it could inadvertently create files in directories where arbitrary file creation could have unintended side effects.

To mitigate this issue, the behavior has been modified such that DHE parameters are now directed to stdout/stderr by default. Additionally, users have the option to specify a file path using the --dhparams-out=str argument to save the parameters to a file if desired.

This change improves security by ensuring that DHE parameters are handled safely, while still providing users with the flexibility to save them to a file if needed.

* Fixed DHE params output in gnutls-cli-debug

Signed-off-by: Ramesh Adhikari <adhikari.resume at gmail.com>

## Checklist
 * [*] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [*] Code modified for feature
 * [*] Test suite updated with functionality tests
 * [*] Test suite updated with negative tests
 * [] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [*] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1822
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20240316/37a3a933/attachment.html>

More information about the Gnutls-devel mailing list