[gnutls-devel] GnuTLS | lib/accelerated: add missing space on pushsection (!1845)

[Read-only notification of GnuTLS library development activities]

William Roberts created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1845

Project:Branches: wcrobertarm/gnutls:fixes-for-pac-bti-enablement to gnutls/gnutls:master
Author:   William Roberts




Fixs for pac and bti enablement, descriptions in the patches.

* lib/accelerated: add CFLAGS to aarch64/elf

When building with certain cflags, like -mbranch-protection=standard,
the assembly generation needs to get the CFLAGS to enable assembler
level features. Without this, closing PAC/BTI feature support will not
be completed.

Example:
export CFLAGS='-mbranch-protection=standard'
export CPPFLAGS='-mbranch-protection=standard'
\# not needed, just for error reporting
export LDFLAGS='-Wl,-zforce-bti,--fatal-warnings'
./bootstrap
./configure --with-included-libtasn1 --with-included-unistring
make asm-sources
make -j4
readelf -n ./lib/.libs/libgnutls.so

Displaying notes found in: .note.gnu.property
  Owner                Data size 	Description
  GNU                  0x00000010	NT_GNU_PROPERTY_TYPE_0
      Properties: AArch64 feature: BTI, PAC
<snip>

readelf -n ./lib/.libs/libgnutlsxx.so

Displaying notes found in: .note.gnu.property
  Owner                Data size 	Description
  GNU                  0x00000010	NT_GNU_PROPERTY_TYPE_0
      Properties: AArch64 feature: BTI, PAC
<snip>

Related to: #1517

Signed-off-by: Bill Roberts <bill.roberts at arm.com>

* lib/accelerated: add missing space on pushsection

Missing a space between pushsection and the section name.

Results in this error:
lib/accelerated/aarch64/aarch64-common.h:109: Error: unknown pseudo-op: `.pushsection.note.gnu.property'

Signed-off-by: Bill Roberts <bill.roberts at arm.com>

## Checklist
 * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [x] Code modified for feature
 * [x] Test suite updated with functionality tests (existing tests work)
 * [x] Test suite updated with negative tests (existing tests work)
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1845
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20240611/73914f64/attachment-0001.html>