[gnutls-devel] GnuTLS | tests: support KAT in dh-compute* tests (!1813)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Fri Feb 23 07:31:11 CET 2024

Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1813

Project:Branches: dueno/gnutls:wip/dueno/ecdh-compute-tests to gnutls/gnutls:master
Author:   Daiki Ueno

<!-- Add a description of the new feature/bug fix. Reference any relevant bugs. -->

* tests: support KAT in dh-compute* tests

While the logic existed, known answer tests were omitted in
tests/dh-compute, tests/dh-compute2, tests/ecdh-compute, and
tests/ecdh-compute2.  This enables the support for it as well as fixes
a couple of issues in the logic: avoid using `success` variable as it
shadows the helper function with the same name defined in
tests/utils.h, invert the memcmp condition, and properly use peer_x
and peer_y in place of x and y in ecdh-compute2.

Signed-off-by: Daiki Ueno <ueno at gnu.org>

## Checklist
 * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1813
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20240223/8de9be17/attachment.html>

More information about the Gnutls-devel mailing list