[gnutls-devel] GnuTLS | tests: Find p11-kit module directory via pkg-config. (!1913)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Fri Dec 27 09:54:28 CET 2024
Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1913 was reviewed by Daiki Ueno
--
Daiki Ueno started a new discussion on tests/p11-kit-load.sh: https://gitlab.com/gnutls/gnutls/-/merge_requests/1913#note_2275220759
> +P11_MODULE_PATH=$(${PKG_CONFIG} p11-kit-1 --variable=p11_module_path)
> +
> +for lib in "${P11_MODULE_PATH}" ${libdir} ${libdir}/pkcs11 /usr/lib64/pkcs11/ /usr/lib/pkcs11/ /usr/lib/x86_64-linux-gnu/pkcs11/;do
Not a fault of this MR, but shouldn't we also quote `${libdir}` here? Maybe we should consider running ShellCheck as part of CI.
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1913
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20241227/282b375e/attachment.html>
More information about the Gnutls-devel
mailing list