[gnutls-devel] GnuTLS | getline() functions calls' result handling (#1573)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Tue Aug 20 02:48:48 CEST 2024
Daiki Ueno commented on a discussion: https://gitlab.com/gnutls/gnutls/-/issues/1573#note_2060720816
The general workflow to create a merge-request can be found in the GitLab documentation: https://docs.gitlab.com/ee/user/project/merge_requests/creating_merge_requests.html
There is also a GnuTLS specific contribution guide in the repository: https://gitlab.com/gnutls/gnutls/-/blob/master/CONTRIBUTING.md?ref_type=heads
> P.S. In addition for memory leaks theme: there is potential descriptor leak [there](https://gitlab.com/gnutls/gnutls/-/blob/master/lib/x509/verify-high2.c#L391) in analogy when we [fast-end return](https://gitlab.com/gnutls/gnutls/-/blob/master/lib/x509/verify-high2.c#L398) (without **`closedir()`** calling). I think these fixes can be committed together (or it needs it's own issue created?)
Good catch; I'd suggest splitting them in separate commits, though it's perfectly fine to include all of them in the same merge-request.
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1573#note_2060720816
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20240820/7a4e5e7c/attachment-0001.html>
More information about the Gnutls-devel
mailing list