[gnutls-devel] GnuTLS | gnutls_privkey_derive_secret: new function (!1773)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1773 was reviewed by Daiki Ueno

--
  
Daiki Ueno commented on a discussion on lib/privkey_raw.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1541137443

> + * @flags: flags from %gnutls_abstract_export_flags_t
> + *
> + * This function will export the DSA private key's parameters found

Yeah, it's a copy and paste error. Replaced with "Diffie-Hellman".

--
  
Daiki Ueno commented on a discussion on lib/privkey_raw.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1541137453

> +				 unsigned int flags)
> +{
> +	return gnutls_privkey_export_dsa_raw2(key, p, q, g, y, x, 0);

Fixed to propagate the flags.

--
  
Daiki Ueno commented on a discussion on lib/x509/privkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1541137458

> +	}
> +
> +	if (_gnutls_mpi_init_scan_nz(&key->params.params[4], x->data,

It simply maps to `mpz_import`, which I don't think constant-time; I'm not sure if we should make it so, as only the length could leak.

--
  
Daiki Ueno commented on a discussion on lib/x509/privkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773#note_1541137464

> +
> +	if (q) {
> +		if (_gnutls_mpi_init_scan_nz(&key->params.params[1], q->data,

Good point; I did some further refactoring on that, also in the DSA code.




-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1773
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20230904/974994f4/attachment-0001.html>