[gnutls-devel] GnuTLS | Add NO_STATUS_REQUEST priority string modifier (!1650)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Tue Oct 11 08:15:14 CEST 2022

Daiki Ueno started a new discussion on lib/ext/status_request.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1650#note_1130878303

>  	status_request_ext_st *priv;
>  	int ret;
> +	if (session->internals.priorities->no_status_request)

So what I wanted to write was:

We now have 3 places to check whether status_request is enabled:
- `session->internals.priorities->no_status_request` (set by priority string)
- `session->internals.flags & GNUTLS_NO_STATUS_REQUEST` (set by `gnutls_init`)
- `_gnutls_hello_ext_get_priv(session, GNUTLS_EXTENSION_STATUS_REQUEST, &epriv);` (set by `gnutls_ocsp_status_request_enable_client`)

Can we consolidate them? I find `session->internals.flags & GNUTLS_NO_STATUS_REQUEST` the most obvious among others.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1650#note_1130878303
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20221011/66572102/attachment-0001.html>

More information about the Gnutls-devel mailing list