[gnutls-devel] GnuTLS | Indent code. (!1671)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Sat Nov 26 20:51:57 CET 2022



Simon Josefsson created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1671

Project:Branches: jas/gnutls:jas/indent to gnutls/gnutls:master
Author:   Simon Josefsson




This indents all code using 'indent -ppi1 -linux' and sets up CI/CD check to catch regressions, fixing #1419.  I believe it is ready for review and ultimately merge.  What do you think?

The only surprising part was the fix to silence 'make syntax-check' (which is run during CI/CD before this merge request): I have no idea why that didn't trigger before since clearly lib/cert-cred.c contains user-translatable strings.  Even though it is unrelated to code indentation, I hope it is acceptable to fix that problem through this merge request.

## Checklist
 * [X] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [X] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1671
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20221126/40a42d15/attachment.html>


More information about the Gnutls-devel mailing list