[gnutls-devel] GnuTLS | Indent code? (#1419)

Mon Nov 7 10:01:58 CET 2022

Simon Josefsson commented:

For libidn2 I'm using stages 'quick', 'build' (bootstrap), and 'test' (tarball) that includes 'make syntax-check' which checks indentation -- see output https://gitlab.com/libidn/libidn2/-/pipelines/682199532 -- the 'quick' test is supposed to be one non-parallel work to check as much as possible before starting all the other builds.  However my experience with this is that I'm not sure it is worth it -- it adds complexity.  I think it is better to not use stages for this -- but instead put all bootstrap-jobs in one stage, which would depend on a single bootstrap-job that does syntax checking.  This has the same advantages (saving CPU cycles) with less complexity.  I'm working on a generalized CI/CD rule for all projects I'm working on (libidn, libidn2, gsasl, libgssglue, libntlm, libtasn1, shishi, gss, ...) right now and will try that approach for it.

I haven't used pre-commit's recently, do they run on the developer's laptop?  My experience with those mechanisms is that they are more fragile and harder to maintain than keeping CI/CD operational (which normally is at least rather reproducible and with public logs).  And when pre-commit tasks start to consume CPU time, developers are rightly annoyed because it gets in the way of work.  The 'make syntax-check' approach is quite nice IMHO, but it does require a ./bootstrap run which is sometimes expensive.   Hmm.  Gnulib does ship a 'GNUmakefile' which will work without bootstrapping.  How about seeing if we can use it do a 'make quick-syntax-check' rule that doesn't require bootstrapping?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/issues/1419#note_1161957218
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20221107/f22cae1c/attachment-0001.html>