[gnutls-devel] GnuTLS | Fix matching of last key of a pkcs#11 token (!1560)
Read-only notification of GnuTLS library development activities
gnutls-devel at lists.gnutls.org
Mon Mar 28 12:29:56 CEST 2022
Benjamin Herrenschmidt commented on a discussion on lib/pkcs11.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1560#note_891176935
> }
>
> if (current > list->key_ids_size)
> break;
Ah yes, you are right, I missed that ! It's actually a somewhat different bug, ie, that code is buggy regardless of whether you apply my change or not. If for some obscure reason the first round of find_objects returns a smaller number of objects than the second one, the array will everflow even without my change. Hopefully that never happens.
I can fold that fix in an updated version of this PR, though I'd rather make it a separate commit as I think it's fundamentally a different bug in that code.
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1560#note_891176935
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220328/08d5f4b0/attachment.html>
More information about the Gnutls-devel
mailing list