[gnutls-devel] GnuTLS | Use custom free/realloc for GMP to safely delete temporary secrets (!1554)

[Read-only notification of GnuTLS library development activities]

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1554 was reviewed by Alexander Sosedkin

--
  
Alexander Sosedkin commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/1554#note_877386489

... but then we don't zeroize, do we? Rendering this a partial fix until it starts passing the correct values.

--
  
Alexander Sosedkin started a new discussion on lib/safe-memfuncs.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1554#note_877386494

> +		newptr = realloc(data, new_size);
> +		if (newptr == NULL)
> +			abort();

Why abort and not propagate?

--
  
Alexander Sosedkin started a new discussion on lib/safe-memfuncs.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1554#note_877386496

> +		newptr = malloc(new_size);
> +		if (newptr == NULL)
> +			abort();

Ditto.

--
  
Alexander Sosedkin started a new discussion on lib/safe-memfuncs.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1554#note_877386498

> +	newptr = malloc(new_size);
> +	if (newptr == NULL)
> +		abort();

Ditto.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1554
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220316/26756eb9/attachment-0001.html>