[gnutls-devel] GnuTLS | remove autogen dependency (!1506)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Fri Jan 14 08:54:34 CET 2022




Daiki Ueno commented on a discussion on src/cfg.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_810492620

> +			if (c == EOF) {
> +				break;
> +			}
> +			if (c == '\n') {
> +				buffer_append(&buffer, ' ');
> +			} else if (c == quote_char) {
> +				buffer_append(&buffer, c);
> +			}
> +		} else if (c == quote_char) {
> +			break;
> +		} else {
> +			buffer_append(&buffer, c);
> +		}
> +	}
> +
> +	return buffer.length == 0 ? strdup("") : buffer.data;

Yeah, I understand; looking at the code, implicit NUL termination in the callee seems to be complicating the things - I've moved the NUL termination to the caller, and also added tests.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1506#note_810492620
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220114/6a1912b1/attachment.html>


More information about the Gnutls-devel mailing list