[gnutls-devel] GnuTLS | Draft: doc/examples: retry on sending in echo servers (!1529)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Thu Feb 10 11:08:23 CET 2022

Alexander Sosedkin created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/1529

Project:Branches: asosedkin/gnutls:examples-retrying to gnutls/gnutls:master
Author:   Alexander Sosedkin

I've noticed that the examples don't handle `GNUTLS_E_INTERRUPTED`/`GNUTLS_E_AGAIN` the way the `gnutls_record_send` prescribe, likely an omission in ca86194b50559abc99d1429dfa7c5f9f78997d9e. I've sketched up what I'd like to see changed about it for one of the echo servers:
* `LOOP_CHECK` on echoing back
* rename `LOOP_CHECK` to not give an impression that it asserts non-negative retcodes 
* `CHECK` separately after using this construct where applicable

but there are many of them, so I'm deferring this work. Will be happy if somebody else picks it up or points out problems with the proposed changes.

## Checklist
 * [ ] Commits have `Signed-off-by:` with name/author being identical to the commit author
 * [ ] Code modified for feature
 * [ ] Test suite updated with functionality tests
 * [ ] Test suite updated with negative tests
 * [ ] Documentation updated / NEWS entry present (for non-trivial changes)
 * [ ] CI timeout is 2h or higher (see Settings/CICD/General pipelines/Timeout)

## Reviewer's checklist:
 * [ ] Any issues marked for closing are addressed
 * [ ] There is a test suite reasonably covering new functionality or modifications
 * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md`
 * [ ] This feature/change has adequate documentation added
 * [ ] No obvious mistakes in the code

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1529
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220210/a934a0b4/attachment.html>

More information about the Gnutls-devel mailing list