[gnutls-devel] GnuTLS | Indent code. (!1671)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Fri Dec 2 10:18:21 CET 2022



Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1671 was reviewed by Daiki Ueno

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on lib/tls13/key_update.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1671#note_1193979865

> -			  "disabling KTLS: couldn't update keys\n");\
> -	}\
> +static void set_ktls_keys(gnutls_session_t session,

This code looks trivial enough to define as `static inline`?

--
  <!-- Get preloaded note discussion-->
  
Daiki Ueno started a new discussion on .gitlab-ci.yml: https://gitlab.com/gnutls/gnutls/-/merge_requests/1671#note_1193979889

>    cache: {}
>    script:
>      # we want $ALPINE_BASE_BUILD without git, so we are adding it here

Not sure about the reason behind this, but maybe we could pull in some of the programs in [Dockerfile](https://gitlab.com/gnutls/build-images/-/blob/0369ad541d553197d18ea5ccdb67119889399739/docker-alpine-base/Dockerfile#L7) instead of here?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1671
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20221202/8905769b/attachment-0001.html>


More information about the Gnutls-devel mailing list