[gnutls-devel] GnuTLS | accelerated: clear AVX bits if it cannot be queried through XSAVE (!1631)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Tue Aug 16 14:01:22 CEST 2022

Daiki Ueno commented on a discussion on lib/accelerated/x86/x86-common.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1631#note_1066051813

>  {
>  	uint32_t xcr0;
> -	if ((ecx & OSXSAVE_MASK) != OSXSAVE_MASK)
> +	if ((ecx & bit_OSXSAVE) != bit_OSXSAVE)

This check is to detect support for `xgetbv`, which we use on the following line. We could check MOVBE here, but it can be detected independently on XSAVE, so I guess we should move the check to `check_avx_movbe` (it's currently missing; good catch).

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1631#note_1066051813
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20220816/64307e7f/attachment.html>

More information about the Gnutls-devel mailing list