[gnutls-devel] GnuTLS | wrap_nettle_hash_exists: add missing hash algorithms (!1473)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Mon Sep 20 14:34:46 CEST 2021

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1473 was reviewed by Alexander Sosedkin

Alexander Sosedkin started a new discussion on tests/simple.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1473#note_682002886

> +				const char *name = gnutls_digest_get_name(hash);
> +				if (gnutls_digest_get_id(name) != hash)
> +					fail("gnutls_digest id's for %s doesn't match %s\n",

If it's a pluralization, there's a plurality mismatch, I think it should be either "id doesn't match" or "id's don't match" + x3 times in the file.

Alexander Sosedkin commented on a discussion on tests/simple.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1473#note_682002888

>  				fail("gnutls_sign id's doesn't match\n");
> +
> +			if (gnutls_sign_is_secure(algs[i])) {

> gnutls_digest_get_id only succeeds with implemented algorithms

I only see `gnutls_digest_get_id` checking `_gnutls_digest_exists` checking `is_mac_algo_forbidden` (FIPS restrictions only) and `wrap_nettle_mac_exists` (from the above chunk).

Alexander Sosedkin commented:

LGTM with one more nitpick.

Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1473
You're receiving this email because of your account on gitlab.com.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20210920/2f0a6598/attachment.html>

More information about the Gnutls-devel mailing list