[gnutls-devel] GnuTLS | priority: fix potential race in reloading system-wide config (!1482)

Read-only notification of GnuTLS library development activities gnutls-devel at lists.gnutls.org
Fri Oct 29 14:54:48 CEST 2021




Alexander Sosedkin commented:


LGTM.

As you have [rightfully noted](https://bugzilla.redhat.com/show_bug.cgi?id=2012249#c12), there's also write access to `system_wide_priority_strings` in `_gnutls_unload_system_priorities()`, but this is only called from `_gnutls_global_deinit()`, which isn't supposed to be thread-safe.

One thing that caught my attention while reviewing this: we also don't clear `system_wide_priority_strings_init` there (or anywhere). That doesn't sound right if one deinits and then reinits, is that a valid scenario?

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1482#note_718509521
You're receiving this email because of your account on gitlab.com.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnutls-devel/attachments/20211029/dd335581/attachment.html>


More information about the Gnutls-devel mailing list